Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8245] – Update "Add Node Pools" description in LKE Create flow #10578

Merged

Conversation

dwiley-akamai
Copy link
Contributor

Description πŸ“

Conditionally update description for "Add Node Pools" section in LKE Create flow if LDE is enabled.

Target release date πŸ—“οΈ

6/24

Preview πŸ“·

Before After
Screenshot 2024-06-13 at 12 13 06β€―PM Screenshot 2024-06-13 at 12 12 57β€―PM

How to test πŸ§ͺ

Prerequisites

  1. Have the linode_disk_encryption tag on your account
  2. Point at the alpha/dev environment
  3. Have the Linode Disk Encryption (LDE) flag in our dev tool toggled on

Verification steps

Without the tag and/or with the LDE flag in our dev tool toggled off, you should not see any LDE-related things in the UI. In this PR, that means you should see the same

Add groups of Linodes to your cluster. You can have a maximum of 100 Linodes per node pool.

copy as you do in prod. Otherwise, you should see

Add groups of Linodes to your cluster. You can have a maximum of 250 Linodes per node pool. Node Pool data is encrypted at rest.

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@dwiley-akamai dwiley-akamai added the Linode Disk Encryption (LDE) Relating to LDE project label Jun 13, 2024
@dwiley-akamai dwiley-akamai self-assigned this Jun 13, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner June 13, 2024 16:25
@dwiley-akamai dwiley-akamai requested review from hana-linode and cpathipa and removed request for a team June 13, 2024 16:25
Copy link

github-actions bot commented Jun 13, 2024

Coverage Report: βœ…
Base Coverage: 82.85%
Current Coverage: 82.85%

Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Is it safe to assume that every region that supports LKE also supports Linode disk encryption or is a separate thing? I'm wondering because we're rendering this copy without checking if the selected region has the "Disk Encryption" capability

@hana-linode hana-linode added the Approved Multiple approvals and ready to merge! label Jun 14, 2024
@dwiley-akamai
Copy link
Contributor Author

Is it safe to assume that every region that supports LKE also supports Linode disk encryption or is a separate thing? I'm wondering because we're rendering this copy without checking if the selected region has the "Disk Encryption" capability

Thanks for raising this, I confirmed there will in fact be a period of time where there won't be perfect overlap between the list of regions that support LKE and the list of regions that support LDE. Pushing up an adjustment momentarily

@dwiley-akamai dwiley-akamai merged commit fb9c2d2 into linode:develop Jun 17, 2024
18 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8245-lke-create-copy-updates branch June 17, 2024 14:12
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Linode Disk Encryption (LDE) Relating to LDE project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants