-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8245] β Update "Add Node Pools" description in LKE Create flow #10578
upcoming: [M3-8245] β Update "Add Node Pools" description in LKE Create flow #10578
Conversation
Coverage Report: β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Is it safe to assume that every region that supports LKE also supports Linode disk encryption or is a separate thing? I'm wondering because we're rendering this copy without checking if the selected region has the "Disk Encryption" capability
packages/manager/src/features/Kubernetes/CreateCluster/NodePoolPanel.tsx
Show resolved
Hide resolved
Thanks for raising this, I confirmed there will in fact be a period of time where there won't be perfect overlap between the list of regions that support LKE and the list of regions that support LDE. Pushing up an adjustment momentarily |
β¦act.FunctionComponent removal in NodePoolPanel.tsx
Description π
Conditionally update description for "Add Node Pools" section in LKE Create flow if LDE is enabled.
Target release date ποΈ
6/24
Preview π·
How to test π§ͺ
Prerequisites
linode_disk_encryption
tag on your accountVerification steps
Without the tag and/or with the LDE flag in our dev tool toggled off, you should not see any LDE-related things in the UI. In this PR, that means you should see the same
Add groups of Linodes to your cluster. You can have a maximum of 100 Linodes per node pool.
copy as you do in prod. Otherwise, you should see
Add groups of Linodes to your cluster. You can have a maximum of 250 Linodes per node pool. Node Pool data is encrypted at rest.
As an Author I have considered π€