Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [M3-8269] - Accessibility: Add tabindex to TextTooltip #10590

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix: [M3-8269] - Accessibility: Add tabindex to TextTooltip #10590

merged 2 commits into from
Jun 18, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Jun 18, 2024 •
edited
Loading

Description 📝

Small PR to add a missing TabIndex to the TextTooltip so that we can properly trigger the tooltip while navigation tabbing.

Changes 🔄

  • Add a missing TabIndex to the TextTooltip

Preview 📷

Screenshot 2024-06-18 at 10 32 43

How to test 🧪

Verification steps

  • One example where this can be tested is the Linode Create flow in the Plan Selection GPU tab, as shown in screenshot

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Jun 18, 2024
@abailly-akamai abailly-akamai added the Accessibility Contains accessibility improvements or changes label Jun 18, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review June 18, 2024 14:47
@abailly-akamai abailly-akamai requested a review from a team as a code owner June 18, 2024 14:47
@abailly-akamai abailly-akamai requested review from mjac0bs and hkhalil-akamai and removed request for a team June 18, 2024 14:47
@github-actions GitHub Actions
Copy link

Coverage Report: ✅
Base Coverage: 82.85%
Current Coverage: 82.85%

mjac0bs
mjac0bs approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Tested this by confirming I can now see the text tooltip in the Create Bucket Drawer via keyboard nav.

Prod Fixed on This Branch
Screen.Recording.2024-06-18.at.12.31.20.PM.mov
Screen.Recording.2024-06-18.at.12.30.48.PM.mov

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Jun 18, 2024
hkhalil-akamai
hkhalil-akamai approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@abailly-akamai abailly-akamai merged commit a95b715 into linode:develop Jun 18, 2024
18 checks passed
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Jun 19, 2024
@abailly-akamai @nikhagra-akamai
fix: [M3-8269] - Accessibility: Add tabindex to TextTooltip (linode#1…
f3c0120 
…0590)

* Add tabindex to TextTooltip

* Added changeset: Accessibility: Add tabindex to TextTooltip
This was referenced Jun 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkhalil-akamai hkhalil-akamai hkhalil-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

Assignees

@abailly-akamai abailly-akamai

Labels
Accessibility Contains accessibility improvements or changes Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abailly-akamai @mjac0bs @bnussman-akamai @hkhalil-akamai