fix: Object Storage Object URLs #10603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
|
Coverage Report: ✅ |
abailly-akamai
previously approved these changes
Jun 21, 2024
| ? buckets?.buckets.find( | ||
| (bucket) => bucket.label === bucketName && bucket.region === clusterId | ||
| )?.cluster ?? '' | ||
| : clusterId; |
There was a problem hiding this comment.
I can see how you don't find this ideal - perhaps rendering a separate component if isObjMultiClusterEnabled is true to only fetch in that case can be considered as a refactor follow up
cpathipa
approved these changes
Jun 21, 2024
abailly-akamai
approved these changes
Jun 21, 2024
| return bucket.label === bucketName && bucket.region === clusterId; | ||
| } | ||
| return bucket.label === bucketName && bucket.cluster === clusterId; | ||
| }); |
There was a problem hiding this comment.
does seem to delay the loading of the URL but there's another loading pattern on the page so i think we're ok
dwiley-akamai
approved these changes
Jun 21, 2024
hana-akamai
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The Issue 🐛
Preview 📷
Screen.Recording.2024-06-21.at.3.30.21.PM.mov
Screen.Recording.2024-06-21.at.3.29.41.PM.mov
How to test 🧪
As an Author I have considered 🤔