-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: [M3-8008, M3-8277] - Update invoices for JP and EU #10606
Merged
jaalah-akamai
merged 10 commits into
linode:release-v1.122.0
from
jaalah-akamai:M3-8008
Jun 24, 2024
Merged
added: [M3-8008, M3-8277] - Update invoices for JP and EU #10606
jaalah-akamai
merged 10 commits into
linode:release-v1.122.0
from
jaalah-akamai:M3-8008
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
requested review from
bnussman-akamai and
hana-akamai
and removed request for
a team
June 24, 2024 12:00
Coverage Report: ✅ |
jaalah-akamai
changed the title
added: [M3-8008] - Standard Tax Rate for JP
added: [M3-8008, M3-8277] - Update invoices for JP and EU
Jun 24, 2024
jaalah-akamai
commented
Jun 24, 2024
packages/manager/src/features/Billing/PdfGenerator/PdfGenerator.ts
Outdated
Show resolved
Hide resolved
cpathipa
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/features/Billing/PdfGenerator/PdfGenerator.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Billing/PdfGenerator/PdfGenerator.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Billing/PdfGenerator/PdfGenerator.ts
Outdated
Show resolved
Hide resolved
…r.ts Co-authored-by: Banks Nussman <[email protected]>
dwiley-akamai
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observed the required additions for JP and EU invoices ✅
jaalah-akamai
merged commit Jun 24, 2024
f284f8c
into
linode:release-v1.122.0
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
Standard Tax is 10%
to the JP invoicesSwitzerland VAT: CHE-115.356.067 MWST
for EU B2B invoicesLD additions to Tax object:
Target release date 🗓️
6/24
Preview 📷
Note
Swiss:
has been updated toSwitzerland VAT:
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Standard Tax is 10%
appears under Tax Id's (top left side in invoice).As an Author I have considered 🤔
Check all that apply