Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: [M3-8008, M3-8277] - Update invoices for JP and EU #10606

Merged
merged 10 commits into from
Jun 24, 2024

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Jun 24, 2024

Description 📝

  1. For JP customers, invoices must include both a QI Registration # and the tax rate in order to apply for purchase tax credit. This adds the tax rate to the invoice.
  2. For EU customers, invoices will include VAT for B2C transactions and exclude VAT for B2B transactions. We will show both the VAT and B2B tax id numbers on the invoice template for EU countries.

Changes 🔄

  • Created country map for targeting
  • Added Standard Tax is 10% to the JP invoices
  • Added Switzerland VAT: CHE-115.356.067 MWST for EU B2B invoices

LD additions to Tax object:

"tax_ids": {
  "B2B": {
    "tax_id": "CHE-115.356.067 MWST",
    "tax_name": "Switzerland VAT"
  }
}

Target release date 🗓️

6/24

Preview 📷

Screenshot 2024-06-24 at 9 45 39 AM

Note

Swiss: has been updated to Switzerland VAT:

Screenshot 2024-06-24 at 11 15 00 AM

How to test 🧪

Prerequisites

(How to setup test environment)

  • Turn on MSW
  • Change account country to "JP" in MSW
  • Afterwards do the same for any EU country to verify Swiss Tax ID

Verification steps

(How to verify changes)

  • Navigate to http://localhost:3000/account/billing
  • Click on Download invoice and verify Standard Tax is 10% appears under Tax Id's (top left side in invoice).
  • After changing country to any country in the EU, observe Switzerland Tax ID is visible

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai jaalah-akamai self-assigned this Jun 24, 2024
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner June 24, 2024 12:00
@jaalah-akamai jaalah-akamai requested review from bnussman-akamai and hana-akamai and removed request for a team June 24, 2024 12:00
Copy link

github-actions bot commented Jun 24, 2024

Coverage Report:
Base Coverage: 83.12%
Current Coverage: 83.12%

@jaalah-akamai jaalah-akamai changed the title added: [M3-8008] - Standard Tax Rate for JP added: [M3-8008, M3-8277] - Update invoices for JP and EU Jun 24, 2024
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming JP and EU tax info in invoices.

image

image

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Jun 24, 2024
@dwiley-akamai dwiley-akamai self-requested a review June 24, 2024 14:58
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed the required additions for JP and EU invoices ✅

@jaalah-akamai jaalah-akamai merged commit f284f8c into linode:release-v1.122.0 Jun 24, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants