Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Allow integration and unit tests to run against EOL or desired python version #52

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ykim-akamai
Copy link
Contributor

📝 Description

This PR adds workflow_dispatch inputs to allow e2e tests run against EOL or desired version as an option.
e.g.
image

✔️ How to Test

Forked e2e run with EOL:

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner November 5, 2024 01:54
@ykim-akamai ykim-akamai requested review from lgarber-akamai and yec-akamai and removed request for a team November 5, 2024 01:54
@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label Nov 5, 2024
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good! The forked run seems failed due to a S3UploadFailedError. Is it related to the python version used?

commit_sha:
description: 'The hash value of the commit.'
required: true
python-version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you get a chance, could this fix also be applied here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants