Skip to content

Commit

Permalink
usbnet: ipheth: do not stop RX on failing RX callback
Browse files Browse the repository at this point in the history
RX callbacks can fail for multiple reasons:

* Payload too short
* Payload formatted incorrecly (e.g. bad NCM framing)
* Lack of memory

None of these should cause the driver to seize up.

Make such failures non-critical and continue processing further
incoming URBs.

Signed-off-by: Foster Snowhill <[email protected]>
Signed-off-by: NipaLocal <nipa@local>
  • Loading branch information
Forst authored and NipaLocal committed Aug 7, 2024
1 parent d494cf5 commit 47134db
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/usb/ipheth.c
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ static void ipheth_rcvbulk_callback(struct urb *urb)
if (retval != 0) {
dev_err(&dev->intf->dev, "%s: callback retval: %d\n",
__func__, retval);
return;
}

rx_submit:
Expand Down

0 comments on commit 47134db

Please sign in to comment.