Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add token for coverage test #907

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

MaisenbacherD
Copy link
Contributor

The code coverage action is silently failing partly because the required Codecov token is missing.
Reading the token from the GitHub secrets.

The missing gpg package must be fixed in
https://github.com/linux-nvme/ci-containers.

Furthermore, fail the coverage workflow if the codecov-action errors out.

Please add the CODECOV_TOKEN to the GitHub secrets :)

The code coverage action is silently failing partly because the required
Codecov token is missing.
Reading the token from the GitHub secrets.

The missing gpg package must be fixed in
https://github.com/linux-nvme/ci-containers.

Furthermore, fail the coverage workflow if the codecov-action errors out.

Signed-off-by: Dennis Maisenbacher <[email protected]>
@MaisenbacherD
Copy link
Contributor Author

The missing gpg package was fixed in linux-nvme/ci-containers#3

@igaw
Copy link
Collaborator

igaw commented Oct 31, 2024

I'm trying to figure out to access the nvme-cli group on codedev. Hmm, it could be so easy...

@igaw
Copy link
Collaborator

igaw commented Oct 31, 2024

I couldn't figure out how to get ownership of the project but it seems I do have some sort of permission. I created a global token let's see how this works.

@igaw igaw merged commit 89ea2b7 into linux-nvme:master Oct 31, 2024
15 checks passed
@MaisenbacherD
Copy link
Contributor Author

It looks like the global token can't be associated with a repository:

error - 2024-10-31 17:21:16,837 -- Commit creating failed: {"message":"Repository not found"}

https://github.com/linux-nvme/libnvme/actions/runs/11615796884/job/32347235636
https://github.com/linux-nvme/nvme-cli/actions/runs/11615775763/job/32347164262

There is no obvious argument to specify the codecov repo.
However, after looking closely at the argument list we might have to specify the directory of the coverage.xml if that is not found by default. But this should return a different error after finding the repo.
https://github.com/codecov/codecov-action?tab=readme-ov-file#arguments

@igaw
Copy link
Collaborator

igaw commented Nov 4, 2024

Ah, so the problem is that they changed the permission model. The 'app install step' for the linux-nvme organization has to be done by 'This action must be performed by an organization owner'. I'll talk to @keithbusch :)

https://docs.codecov.com/docs/adding-the-codecov-token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants