configure: Cleanup CUDA configury #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is hard to tell who is maintaining perftests these days, but tagging @HassanKhadour who made the last stable release for review. I do not have triage permissions on this repo to tag reviewers. |
The current approach to enabling CUDA support in the bandwidth benchmarks with an environment variable that takes that path to an include file is extremely fragile. As a low-hanging fruit, this commit brings the CUDA configuration closer to ROCm, but relying on a flag to enable the feature and AC_SEARCH_LIBS to update lib flags, or on --with-cuda allowing a user to provide a custom installation path. Ideally, we should rely on dlopen()'ing the symbols we need from these libraries so a single build of perftest can work on systems with and without CUDA SDK, but that's to come later. Signed-off-by: Raghu Raja <[email protected]>
|
By removing the include of the 'CUDA_PATH' in perftest_parameters.h (line 70) the commit is breaking the backward compatibility. |
|
Indeed, I will fix that up. I am in favor of completely removing it if we can.. given the explicit configure warning (which we can turn into an error) and perhaps a call out in the changelog when this makes it into a release. |
|
Does perftest.spec need a change as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach to enabling CUDA support in the bandwidth
benchmarks with an environment variable that takes that path to an
include file is extremely fragile. As a low-hanging fruit, this commit
brings the CUDA configuration closer to ROCm, but relying on a flag to
enable the feature and AC_SEARCH_LIBS to update lib flags, or on
--with-cuda allowing a user to provide a custom installation path.
Ideally, we should rely on dlopen()'ing the symbols we need from these
libraries so a single build of perftest can work on systems with and
without CUDA SDK, but that's to come later.
Signed-off-by: Raghu Raja [email protected]