Branding proposition + d-wid logo/bootsplash #1506

tlaurion · 2023-10-02T19:00:53Z

This PR is an attempt to fix #1468 by adapting #1502 from @d-wid amazing work.

@JonathonHall-Purism would like to hear from you on Makefile change and branding/Heads directory and qemu config used as example to use the default brand_name.

@d-wid : this PR works, but as stated inside of the commit message here:

the xcf is too big to be accepted under master: that would add 4mb of download to anyone downloading the heads tree. We need to make sure that what is accepted, even more when binary data, is not gonna change much in the future.
the commit message of the squash commit under logo, bootsplash upload from me #1502 should be clearer and the filenames referencing the authors of the images. Please read commit and ping me if its possible for you to change the commit message/filenames to reflect this. If not, please challenge me on the xcf utility (not a designer here) to justify presence under git tree forever.

I would then take your work, and modify this PR accordingy to have all coreboot configs point to the bootsplash as depicted by this PR and modify Makefile following remarks here and either merge this PR and or yours to have proper branding with logo/bootsplashes produced.

@d-wid sorry for those back and forths!

d-wid · 2023-10-03T00:58:07Z

the xcf is too big to be accepted under master: that would add 4mb of download to anyone downloading the heads tree. We need to make sure that what is accepted, even more when binary data, is not gonna change much in the future.

Hi, I don't actually expect the xcf (from which all the jpges were sourced, with some layer manipulation) to be merged into master. The idea is that that PR serves as a repository of what I come up with, the xcf is there so that people can build on it (in the exact same way I did on the original from @Thrilleratplay ), or change the donation QR code etc without applying the JPEG compression again. Same idea with the svg. If you want to put it somewhere on the readme, website etc you can, and in any size you want, but it's obviously not a splash image (though I've just noticed the svg is pretty negligible in size compared to the xcf).

I guess I could remove the xcf and put it in my own repo somewhere, if that works. Otherwise would you (all) prefer a new jpg-only or xcf-only PR right here to keep xcf inside the Heads github in some form? Oh wait. This is the "another PR" you referred to in #1502. In that case yeah, I see no reason for the xcf to stay here from a purely end user POV.

Is the plan to merge all the jpegs? In that case I think @ThePlexus gets the credit for the box if I remember correctly.

properly credit previous authors in the present PR?

What do you mean by properly? In any case @Thrilleratplay probably gets credit for all the images since they're all just new layers on top of some of his existing ones (though it's not always the case anymore that any of his layers remain visible, not sure how that works but probably not something I ought to stress about too much?). The box versions were copied from @ThePlexus , and the Heads logo used (and the colour scheme in the tricolour version) gets credited to Microsoft of all people lol.

tlaurion · 2023-10-03T14:29:27Z

I guess I could remove the xcf and put it in my own repo somewhere, if that works. Otherwise would you (all) prefer a new jpg-only or xcf-only PR right here to keep xcf inside the Heads github in some form? Oh wait. This is the "another PR" you referred to in #1502. In that case yeah, I see no reason for the xcf to stay here from a purely end user POV.

Is the plan to merge all the jpegs? In that case I think @ThePlexus gets the credit for the box if I remember correctly.

properly credit previous authors in the present PR?

What do you mean by properly? In any case @Thrilleratplay probably gets credit for all the images since they're all just new layers on top of some of his existing ones (though it's not always the case anymore that any of his layers remain visible, not sure how that works but probably not something I ought to stress about too much?). The box versions were copied from @ThePlexus , and the Heads logo used (and the colour scheme in the tricolour version) gets credited to Microsoft of all people lol.

I think I addressed all comments but squashing my commit and #1502 on previous commit.
Next commit will squash both and remove you as author to be able to remove the xcf so merging will not pollute history with binary image. I think CREDITS does a good job referencing Bing, authors and remixers, let me know.

@ThePlexus @Thrilleratplay @d-wid Please look at branding/Heads/CREDITS and let me know if something is wrong.

tlaurion · 2023-10-03T14:44:00Z

Next commit will squash both and remove you as author to be able to remove the xcf so merging will not pollute history with binary image. I think CREDITS does a good job referencing Bing, authors and remixers, let me know.

Nicer then I thought. @d-wid we are now co-authors on your last commit here after squashing your commit with mine.

tlaurion · 2023-10-03T15:16:23Z

This is what it looks like with currently selected default on qemu, emulating the same result obtained for real hardware boards

JonathonHall-Purism · 2023-10-04T12:19:28Z

@JonathonHall-Purism would like to hear from you on Makefile change and branding/Heads directory and qemu config used as example to use the default brand_name.

Thanks! I think this is a pretty reasonable approach. It's nice to tie the brand name and bootsplash together since they are related.

tlaurion · 2023-10-04T21:12:29Z

@d-wid @Thrilleratplay @ThePlexus : a quick review on CREDITS file please? Otherwise I will merge probably by the end of the week!

d-wid · 2023-10-04T21:37:58Z

It would be more correct to say that the svg (instead any of the jpegs into which the svg was imported) was the result of Inkscape automatically smoothing out a the Bing image (after I made it all black with gimp). Bing itself didn't spit out anything in vector form after all. Otherwise I think it looks alright.

…

On 4 October 2023 21:12:40 UTC, tlaurion ***@***.***> wrote: @d-wid @Thrilleratplay @ThePlexus : a quick review on CREDITS file please? -- Reply to this email directly or view it on GitHub: #1506 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

tlaurion · 2023-10-04T21:55:49Z

It would be more correct to say that the svg (instead any of the jpegs into which the svg was imported) was the result of Inkscape automatically smoothing out a the Bing image (after I made it all black with gimp). Bing itself didn't spit out anything in vector form after all.

Otherwise I think it looks alright.

On 4 October 2023 21:12:40 UTC, tlaurion @.***> wrote:

@d-wid @Thrilleratplay @ThePlexus : a quick review on CREDITS file please?

--
Reply to this email directly or view it on GitHub:
#1506 (comment)
You are receiving this because you were mentioned.

Message ID: @.***>

Any direct change you want to see @d-wid in the CREDITS file? That would be helpful! Otherwise I'll try to represent your suggestion as best as I can, but this is why we love diff/git :)

d-wid · 2023-10-04T22:44:04Z

Something along the lines of: bing-d-wid_logo.svg: Heads Logo generated by Bing's AI on August 03 2023 with prompt "Double Headed Janus Logo for Heads Open Source Firmware" shared under #1402 (comment) *edited with GIMP and traced with Inkscape* bing-d-wid_heads-red_blue_background-plain-3_DonateQrCode.jpg: @d-wid remix of Bing's Heads logo + DonateQrCode

Thrilleratplay · 2023-10-05T02:55:22Z

@tlaurion I appreciate offering credit for the trivial bit of a background I threw together by sending one of the coreboot source files (I can't remember which) into a binary encoder and pasting into GIMP, but feel it is unwarranted. Had I not been so busy the past few days, I would have said not to bother mentioning me. Oh well. Thank you. These look awesome.

tlaurion · 2023-10-06T18:19:15Z

@d-wid sorry for delay.
aaf8698 's CREDIT file looks fine?

Just implemented requested changes which reflects directly your comments at #1506 (comment)

Will merge in ~2 hours. This is benign change after all.

d-wid · 2023-10-06T20:05:07Z

Yeah I think so. I meant for the "*" characters to result in italics in the above comment instead of appearing in the txt file and the last three pictures might also need "+DonateQrCode" added to them but those are minor points not worth getting boddeg down over.

…

On 6 October 2023 18:19:25 UTC, tlaurion ***@***.***> wrote: @d-wid sorry for delay. aaf8698 looks fine? -- Reply to this email directly or view it on GitHub: #1506 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

@d-wid

Squash of linuxboot#1502 + moving logo/bootsplash files under branding/Heads - Move logos and bootsplashes from blobs to branding/Heads/ - Makefile: add support for BRAND_DIR which depends on BRAND_NAME which defaults to Heads if no branding - Boards coreboot configs: change bootsplash directory to depend on BRAND_DIR (instead of BLOBS_DIR) in bootsplash enabled configs - Branding/Heads/bootsplash-1024x768.jpg points to branding/Heads/d-wid-ThePlexus_coreboot-linuxboot-heads_background-plain_DonateQrCode.jpg - xcf file deleted. Original still under linuxboot#1502 to reuse for modification without recompressing (blobs/heads.xcf) - CREDITS file created to point to original authors, remixers (Open for details) - Thanks to: @d-wid for remixing Bing's AI generated Janus logo, @ThePlexus for Qubes Box concept and @Thrilleratplay for its matrix background

tlaurion mentioned this pull request Oct 2, 2023

logo, bootsplash upload from me #1502

Closed

tlaurion marked this pull request as draft October 2, 2023 19:04

tlaurion force-pushed the branding_proposition branch from b0e8eec to c60a254 Compare October 3, 2023 14:26

tlaurion force-pushed the branding_proposition branch from c60a254 to 8c4c425 Compare October 3, 2023 14:34

tlaurion marked this pull request as ready for review October 3, 2023 14:36

tlaurion changed the title ~~Branding proposition + d-wid logo/bootsplash PoC~~ Branding proposition + d-wid logo/bootsplash Oct 3, 2023

tlaurion force-pushed the branding_proposition branch from 8c4c425 to fd74c4e Compare October 3, 2023 14:42

tlaurion force-pushed the branding_proposition branch from fd74c4e to 18a4399 Compare October 3, 2023 14:57

This was referenced Oct 3, 2023

bootsplash: Change default bootsplash to d-dwid-janus-hexa with DonateQrCode #1501

Closed

WiP: Heads logo, heads inside Plexus bootsplash, bootsplash used by default #1451

Closed

tlaurion force-pushed the branding_proposition branch from 18a4399 to aaf8698 Compare October 6, 2023 18:18

tlaurion force-pushed the branding_proposition branch from aaf8698 to 2bfa173 Compare October 6, 2023 21:09

tlaurion merged commit f640fb7 into linuxboot:master Oct 6, 2023
1 check was pending

tlaurion mentioned this pull request Oct 7, 2023

Consider moving bootsplash/logos/branding under branding/ #1427

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Branding proposition + d-wid logo/bootsplash #1506

Branding proposition + d-wid logo/bootsplash #1506

tlaurion commented Oct 2, 2023

d-wid commented Oct 3, 2023 •

edited

Loading

tlaurion commented Oct 3, 2023 •

edited

Loading

tlaurion commented Oct 3, 2023 •

edited

Loading

tlaurion commented Oct 3, 2023 •

edited

Loading

JonathonHall-Purism commented Oct 4, 2023

tlaurion commented Oct 4, 2023 •

edited

Loading

d-wid commented Oct 4, 2023 via email

tlaurion commented Oct 4, 2023 •

edited

Loading

d-wid commented Oct 4, 2023 via email

Thrilleratplay commented Oct 5, 2023

tlaurion commented Oct 6, 2023 •

edited

Loading

d-wid commented Oct 6, 2023 via email

Branding proposition + d-wid logo/bootsplash #1506

Branding proposition + d-wid logo/bootsplash #1506

Conversation

tlaurion commented Oct 2, 2023

d-wid commented Oct 3, 2023 • edited Loading

tlaurion commented Oct 3, 2023 • edited Loading

tlaurion commented Oct 3, 2023 • edited Loading

tlaurion commented Oct 3, 2023 • edited Loading

JonathonHall-Purism commented Oct 4, 2023

tlaurion commented Oct 4, 2023 • edited Loading

d-wid commented Oct 4, 2023 via email

tlaurion commented Oct 4, 2023 • edited Loading

d-wid commented Oct 4, 2023 via email

Thrilleratplay commented Oct 5, 2023

tlaurion commented Oct 6, 2023 • edited Loading

d-wid commented Oct 6, 2023 via email

d-wid commented Oct 3, 2023 •

edited

Loading

tlaurion commented Oct 3, 2023 •

edited

Loading

tlaurion commented Oct 3, 2023 •

edited

Loading

tlaurion commented Oct 3, 2023 •

edited

Loading

tlaurion commented Oct 4, 2023 •

edited

Loading

tlaurion commented Oct 4, 2023 •

edited

Loading

tlaurion commented Oct 6, 2023 •

edited

Loading