Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flash.sh: drop inhouse progress output on console when flashing with flashrom #1755

Merged

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Aug 23, 2024

Flashrom dropped --progress output under 1.2.
flashrom 1.4 still has no --progress output.


Heads implemented in-house progress output as a workaround until fixed upstream.
That never happened.
This is still opened issue https://ticket.coreboot.org/issues/390

As per #1753 (comment) @JonathonHall-Purism comment:

What would you think about removing the progress bar? The dream would be to rework it (maybe doing it in flashrom itself, or at least providing a reliably-parseable progress output), but the current implementation is a huge pain, I don't feel it adds enough value to outweigh the pain. For comparison the read step takes a comparable amount of time and does not have a progress bar.


So here, we drop progress output and leave user in the dark while they erase/write the firmware internally when upgrading Heads.

@tlaurion
Copy link
Collaborator Author

@JonathonHall-Purism works as intended. Merge?

@JonathonHall-Purism
Copy link
Collaborator

💯 Let's merge, thank you @tlaurion

I'm thrilled to see this go. While it's not awesome to leave users with an indefinite wait, it is far better than sometimes freezing during a critical potentially-bricking operation, and this code was a nightmare to maintain.

@tlaurion
Copy link
Collaborator Author

💯 Let's merge, thank you @tlaurion

I'm thrilled to see this go. While it's not awesome to leave users with an indefinite wait, it is far better than sometimes freezing during a critical potentially-bricking operation, and this code was a nightmare to maintain.

@JonathonHall-Purism please approve!

@tlaurion tlaurion merged commit e64685b into linuxboot:master Aug 23, 2024
45 checks passed
@tlaurion
Copy link
Collaborator Author

tlaurion commented Aug 23, 2024

signal-2024-08-23-10-29-29-632.jpg

Master flashrom output for 1.3 with me typing on keyboard in between flashrom stating it will do write erase operations prior of doing them.

Not that bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants