-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T420 initial support + X220 FBWhiptail Support #578
Conversation
…estarting, or during S3 resume. If they actually bring functionality to builds, replace the patch with something that is tested.
This reverts commit 584690f.
…ng up, restarting, or during S3 resume. If they actually bring functionality to builds, replace the patch with something that is tested." This reverts commit 41e5301.
This reverts commit f17c519.
X220 cbmem temp debug requirements
adds the chip option, needed for X220 to actually use this.
Forgot to disable TPM logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should be a seperate PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commit message should better read "blobs/t420: remove gitignore"
boards/t420/t420.config
Outdated
# Configuration for a x220 running Qubes and other OS | ||
# The Linux configuration is close enough to the x230 | ||
export CONFIG_COREBOOT=y | ||
CONFIG_COREBOOT_CONFIG=config/coreboot-x220.config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that correct?
# The Linux configuration is close enough to the x230 | ||
export CONFIG_COREBOOT=y | ||
CONFIG_COREBOOT_CONFIG=config/coreboot-x220.config | ||
CONFIG_LINUX_CONFIG=config/linux-x230.config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if correct, we should add a comment, why, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. If the already existing X220 is close enough to X230, and T420 is close enough to X220, T420 is close enough to X230.
Tested on my T420 as working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be squashed into the previous change that adds t420.config
boards/t420/t420.config
Outdated
export CONFIG_COREBOOT=y | ||
CONFIG_COREBOOT_CONFIG=config/coreboot-t420.config | ||
CONFIG_COREBOOT_CONFIG=config/coreboot-T420.config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really uppercase T?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not do 2 commit when changing 2 board configs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to review this seperately and this has to be a different PR. interesting...
This reverts commit 1e705eb. Reverting that way the new method to obtain flash definitions can be used (seen in osresearch/linuxboot#592)
This reverts commit fe03f79. Revert flash.sh part 2
This branch's flash.sh changes are reverted to conform with #592's way of supplying flash definitions. |
@SebastianMcMillan Have you had a chance to test including ifd and reduce me and changing CBFS size in coreboot config and see if the 60 seconds delay linked to ME disappeared? |
I've not yet had the chance, but I will get around to it by the end of the
month.
…On Wed, Jan 1, 2020, 18:48 tlaurion ***@***.***> wrote:
@SebastianMcMillan <https://github.com/SebastianMcMillan> Have you had a
chance to test
<https://github.com/corna/me_cleaner/wiki/Internal-flashing-with-coreboot#neutralize-and-shrink-intel-me>
including ifd and reduce me and changing CBFS size in coreboot config and
see if the 60 seconds delay linked to ME disappeared?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#578>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNTUNGROWW6DRHTXOEMT5LQ3U2WXANCNFSM4HVNCJ3Q>
.
|
As mentioned in #539 I followed the guide and truncated the ME, still the boot delay is valid. |
Commenting |
I don't believe this is an ME issue. I can use the exact same IFD and ME with stock coreboot and we don't see this issue. Furthermore, using stock ME and IFD still reproduces this issue. This issue is certainly a 4.8.1 issue. I've tested pre 4.8.1 heads on my X220 and can confirm the issue is not present. At this point, I will wait for heads to be based on 4.11+ and see if it's still an issue. |
I would like to already play around a bit. So may I ask how I could switch to old coreboot in the meantime? |
Okay, I used this PR as a basis for my own branch and combined with the hint from @tlaurion it actually works fine now for me! Would @SebastianMcMillan like to separate the x220 stuff as I did and create a new PR as this is tested now, shall we wait or shall I create a PR based on the branch I mentioned above? |
I'll get on that tonight.
…On Tue, Jan 21, 2020, 07:17 Alexander Paetzelt ***@***.***> wrote:
Okay, I used this PR as a basis for my own branch
<#578> and combined with the hint
<#539 (comment)>
from @tlaurion <https://github.com/tlaurion> it actually works fine now
for me!
Would @SebastianMcMillan <https://github.com/SebastianMcMillan> like to
separate the x220 stuff as I did and create a new PR as this is tested now,
shall we wait or shall I create a PR based on the branch I mentioned above?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#578>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNTUNADOGDFM47VHHRFOXLQ63YV7ANCNFSM4HVNCJ3Q>
.
|
@SebastianMcMillan ? |
I apologize on the delay, my T420 is running into some difficulties, and I've been a little caught up with coursework. I am working on testing @tlaurion's suggestion on the X220 as well. |
Fixed Typo for flashrom_options
Added intel_iommu=igfx_off argument
Decreased CBFS size to fix boot delay problems Enabled compiling with any toolchain to prevent build problems Removed check ME option since it fails to check the ME due to the build process not finding me_cleaner
T420 and X220 boot delay fixes tested and confirmed working on my end. |
Fixed boot delay by decreasing CBFS size, removed dysfunctional check ME option, and enabled use of any toolchain.
Separating my original PR #539.
This branch introduces T420 support (complete with FBWhiptail support) and modifications to the X220 to support FBWhiptail.
No known new regressions are present, and this does not fix the 50 second delay that is currently present.