UX Tweaks [2/2] #600
Merged
UX Tweaks [2/2] #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt DeVillier <[email protected]>
Add optional parameter to bypass menu selection and immediately select a menu option. This allows us to call the 'Set Boot Device' option directly, saving the user an unnecessary step. Signed-off-by: Matt DeVillier <[email protected]>
use similar filtering logic as with USB drives to provide the user a more sane list of boot device options. Show user only valid bootable partitions, not block devices. There's no point in showing /dev/nvme0 and /dev/nvme0n1 (eg) when /dev/nvme0n1p[1..n] (eg) exist, as the former are not valid boot devices. Signed-off-by: Matt DeVillier <[email protected]>
Updating TOTP/HOTP is mainly necessary after a user updates their firmware, and no need to force another reboot. Signed-off-by: Matt DeVillier <[email protected]>
If the boot device is invalid or unabled to be mounted and the user opts to select a new boot device, jump directly to that menu option and avoid the additional step of showing the config main menu. Signed-off-by: Matt DeVillier <[email protected]>
Add Full Reset option to clear all GPG keys and user settings, both from the local filesystem and running firmware, and clear/reset the TPM Signed-off-by: Matt DeVillier <[email protected]>
Check that any files added to cbfs exist before attempting to add them, so flashing doesn't fail after a reset. Signed-off-by: Matt DeVillier <[email protected]>
Next prompt will be to ensure GPG key is attached, which defaults to Y, so default here as well for consistency Signed-off-by: Matt DeVillier <[email protected]>
Initial card detection can sometimes fail, so prompt the user to remove/reinsert their GPG card before retrying. Since errexit is likely set, disable it prior to calling --card-status so we can handle the error ourself, then re-set if necessary when done. Signed-off-by: Matt DeVillier <[email protected]>
if user chooses abort option, exit without flashing ROM Signed-off-by: Matt DeVillier <[email protected]>
Librem devices store their serial number as a text file in cbfs; persist this across flashes. Signed-off-by: Matt DeVillier <[email protected]>
kylerankin
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
series of small tweaks to the HEADS UI which improve user experience: