Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gnupg pubkey export an option only in oem-factory-reset #766

Merged
merged 4 commits into from
Aug 6, 2020

Conversation

alex-nitrokey
Copy link
Contributor

Since #758 is merged, users have a option to export GnuPG pubkey if
necessary. Thus, we they do not need to insert a USB drive during
factory reset. Until now the whole process failed just because a user
did not provide a USB drive instead.

This shall be fixed by this commit

Since linuxboot#758 is merged, users have a option to export GnuPG pubkey if
necessary. Thus, we they do not need to insert a USB drive during
factory reset. Until now the whole process failed just because a user
did not provide a USB drive instead.

This shall be fixed by this commit
@tlaurion
Copy link
Collaborator

tlaurion commented Jul 3, 2020

As wrongly wrote (sorry) in #764 (comment) :

@alex-nitrokey : I would prefer having mount-usb from preceded with a prompt prior of exporting the keys and keep factory-reset outputing normally to /media if not already mounted.

I will merge my changes to that script in subsequent PR for the reownership wizard to work with upstreamed code, and to me it doesn't really make sense to have a factory reset without exporting the public key.

So in this case, I would set the default to N in the factory-reset script prompt, detect if there is USB drive and not fail but continue?

@alex-nitrokey
Copy link
Contributor Author

So in this case, I would set the default to N in the factory-reset script prompt, detect if there is USB drive and not fail but continue?

Sounds good to me!

@alex-nitrokey
Copy link
Contributor Author

To add: I am preparing a commit accordingly.

@alex-nitrokey alex-nitrokey changed the title Remove gnupg pubkey export in oem-factory-reset Make gnupg pubkey export an option only in oem-factory-reset Jul 7, 2020
@alex-nitrokey
Copy link
Contributor Author

This should be fine now :)

@tlaurion
Copy link
Collaborator

tlaurion commented Aug 1, 2020

@alex-nitrokey : conflict needs to be resolved prior of merging and testing

@alex-nitrokey
Copy link
Contributor Author

Should be good to go again now :)

@tlaurion tlaurion self-assigned this Aug 5, 2020
@tlaurion
Copy link
Collaborator

tlaurion commented Aug 6, 2020

Works as intended.

@tlaurion tlaurion merged commit 5dc65f6 into linuxboot:master Aug 6, 2020
@daringer daringer deleted the gpgexport-factoryreset branch November 15, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants