Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI / Boot Device Tweaks #791

Merged
merged 3 commits into from
Aug 6, 2020
Merged

GUI / Boot Device Tweaks #791

merged 3 commits into from
Aug 6, 2020

Commits on Aug 3, 2020

  1. gui-init: remove double-prompt for checksum update 

    Not need to prompt the user twice for the same action

Signed-off-by: Matt DeVillier <[email protected]>
    @MrChromebox
    MrChromebox committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    244de9d View commit details
    Browse the repository at this point in the history

  2. Fix eval of DEV_NUM_PARTITIONS 

    Using 'let' in these scripts fails when evaluating to zero
for some reason, so replace with '$(())' which works as intended.

Test: Boot device selection menu shown properly when
new/unpartitioned drive installed.

Signed-off-by: Matt DeVillier <[email protected]>
    @MrChromebox
    MrChromebox committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    0afa599 View commit details
    Browse the repository at this point in the history

  3. config-gui: clean up boot device selection 

    When a new /boot device is selected, wait until after
successfully mounting the newly-selected device before
updating CONFIG_BOOT_DEV.

Also, don't assume /boot already mounted, as this can cause
a false failure and prevent mounting of the newly-selected device.

Lastly, tidy up the error output in case mounting /boot fails.

Signed-off-by: Matt DeVillier <[email protected]>
    @MrChromebox
    MrChromebox committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    0b970b7 View commit details
    Browse the repository at this point in the history