Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x220 t420 boards ( replaced with their xx20-external-flash equivalents (needing external flash or unlocked IFD to flash internally ) #913

Closed

Conversation

Thrilleratplay
Copy link
Contributor

Removes X220 and T420 boards.

Wait until #912 has been merged.

@tlaurion tlaurion changed the title Remove x220 t420 Remove x220 t420 boards ( replaced with their xx20-external-flash equivalents (needing external flash or unlocked IFD to flash internally ) Nov 28, 2020
@tlaurion
Copy link
Collaborator

tlaurion commented Dec 1, 2020

Community members have refused removal. We will (hopefully) see xx20/xx30-minimal boards emerge when xx20 and xx30 boards don't produce roms anynore, and guide users to move to their maximized counterparts when the time comes. As a personal statement, I won't maintain xx20 and xx30 boards. New blood needs to make the changes to fit their needs and propose new boards fitting their needs accordingly.

My path is to use freeable ME space (-maximized boards) while I invite everyone else to do the same or to make a board config and relative modules changes that fits their need and propose PRs accordingly.

@tlaurion tlaurion closed this Dec 1, 2020
@paulmenzel
Copy link
Contributor

paulmenzel commented Dec 1, 2020

@Thrilleratplay I only now saw the long merge/pull request description. It’d be great if you added a summary of the goal of the merge/pull request to the description. Also, as an outsider, it’s unclear to me, why such a consolidation would be bad. What are the problems?

@flammit
Copy link
Collaborator

flammit commented Dec 1, 2020

@tlaurion Please don't misrepresent my position. My objection to deprecating the x230 board which is a useful configuration as it stands. I didn't make statements about x220/t420.

@tlaurion
Copy link
Collaborator

tlaurion commented Dec 2, 2020

@flammit : I don't really understand your position to be franck. The x220 board has around 3.5mb of BIOS space in the 8m SPI flash chip. For the xx20 boards to survive, scripts were made to reduce de facto ME. So if I understand your point correctly, your opposition comes solely on unlocking the IFD. But what is proposed for xx20 and xx30 boards, as opposed to newer boards, is ME with only ROMP and BUP modules. I would love, considering this, to understand why you oppose on having an unlocked IFD if ROM is measured and ME is kinda immuable, since the laptop will refuse to boot if those are modified and doesn't match Intel signature. All other modules, are removed.

The logic here is one of maintainership (which lacks to this project as of now for core components). If the same common logic is applied for Sandy/Ivy bridge boards, those boards have a safe future. Otherwise, I'm really not sure. The #913 ticket is opened for more then a year now to resolve #590 issues which are pretty tangled, if you look at tickets which pointed to it. #590 needs love. cryptsetup, gpg, lvm, busybox, the kernel can be tackled to a limit. I think its time to just offer maximum possibilities in terms of space to those boards, while I agree that the timing of deprecating the old generic boards (x220, t420, x230, x230-hotp-verification) is not right. I wil lrepeat though. The moment one of those boards cannot be CI built, or a user reports t420 or x220 cannot be built, I will personally say "i'm sorry. Why are you not upgrading to -maximized counterparts" since I stil ldon't get the logic and why #590 or #913 were not invested prior of that moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants