Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 将dde-appearance 改成插件 #130

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

fly602
Copy link

@fly602 fly602 commented Oct 8, 2024

将dde-appearance 改成deepin-service-manager的插件

将dde-appearance 改成deepin-service-manager的插件
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • DSMRegisterDSMUnRegister函数中,直接使用了qAppqWarning,但没有检查是否已经正确初始化。
  • DSMRegister函数中,appearanceappearance1Adaptor的创建没有考虑线程安全,可能会导致多线程环境下的错误。
  • DSMUnRegister函数中,appearance的删除没有使用deleteLater,可能会导致内存泄漏。
  • DSMRegisterDSMUnRegister函数中,对namedata的参数只进行了空值检查,但没有进行类型检查或进一步的处理。
  • DSMRegister函数中,translator.load可能不会在所有平台上都成功,应该检查翻译文件是否正确加载。
  • DSMRegister函数中,qApp->installTranslator应该在appearance对象存在之前调用,以避免潜在的空指针异常。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602 fly602 merged commit 398b935 into linuxdeepin:master Oct 9, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants