Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move readpipedatatask logic to waylandcopyclient #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: move readpipedatatask logic to waylandcopyclient #149

wants to merge 1 commit into from

Conversation

Decodetalkers
Copy link
Contributor

move the logic to waylandcopyclient, seems it will reduced when the signal cannot received by task

Log:

@Decodetalkers
Copy link
Contributor Author

之前逻辑被封装到qobject里面时候在QtConcurrent中发送的信号经常收不到，尝试移动到waylandclient时候也会有收不到的情况，但是自测后收不到的情况是变少了。我想在qoject里面时候可能也有qobject被销毁的缘故导致连接断开？我想这个pr应该可以改善一点

@Decodetalkers
Copy link
Contributor Author

很奇怪,用watcher观察的话它有时候竟然走不到finish, 这样会造成内存泄漏，所以不是很能搞定这种情况

@Decodetalkers
chore: move readpipedatatask logic to waylandcopyclient
d651729 
move the logic to waylandcopyclient, seems it will reduced when the
signal cannot received by task

Log:
@Decodetalkers
Copy link
Contributor Author

我还是认为这个pr是必要的，因为原来时候在发送信号this执行了deletelater,信号就可能没有成功，而且这个任务本来就不太应该包装到一个class里面，导致信号没有成功发送的频率非常高，至少是修复了这个行为

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justforlxz justforlxz Awaiting requested review from justforlxz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Decodetalkers