Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: hide compact mode" #1727

Closed
wants to merge 2 commits into from
Closed

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Sep 25, 2024

No description provided.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy changed the title Bump version Revert "feat: hide compact mode" Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

TAG Bot

TAG: 6.0.69
EXISTED: no
DISTRIBUTION: unstable

@mhduiy
Copy link
Contributor Author

mhduiy commented Sep 25, 2024

/topic feat-compactMode

@deepin-ci-robot
Copy link

Add topic: feat-compactMode successed.

@deepin-bot
Copy link

deepin-bot bot commented Sep 27, 2024

TAG Bot

New tag: 6.0.67
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1728

@mhduiy
Copy link
Contributor Author

mhduiy commented Sep 27, 2024

startdde 有编译问题, 此PR可以保留, 其余提测可以正常进行

@deepin-bot
Copy link

deepin-bot bot commented Oct 8, 2024

TAG Bot

New tag: 6.0.68
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1729

release version 6.0.69

Log: bump version to 6.0.69
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码重构可能导致功能上的改变,需要确认新的连接方式和状态更新逻辑是否正确。
  • 移除了compactDisplayTipModule的可见性设置,需要确认这是否是有意为之。

是否建议立即修改:

  • 是,需要确保功能上的改动不会引入bug,并且新的模块添加是符合预期的。
  • 是,如果移除compactDisplayTipModule的可见性设置是无意的,应该立即恢复。

@mhduiy
Copy link
Contributor Author

mhduiy commented Oct 8, 2024

/integr-topic feat-compactMode

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#2040

@mhduiy mhduiy closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants