Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 适配vpn和代理 #640

Merged
merged 1 commit into from
Jul 19, 2024
Merged

chore: 适配vpn和代理 #640

merged 1 commit into from
Jul 19, 2024

Conversation

fly602
Copy link
Contributor

@fly602 fly602 commented Jul 19, 2024

1、增加代理变化信号
2、当IP全为空时,自动设置代理为None

Issue: linuxdeepin/developer-center#9710 linuxdeepin/developer-center#9711

1、增加代理变化信号
2、当IP全为空时,自动设置代理为None

Issue: linuxdeepin/developer-center#9710
linuxdeepin/developer-center#9711
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • initProxyGsettings函数中,新增代码逻辑可能存在逻辑错误,应确保当所有代理设置都为空时才设置代理模式为proxyModeNone
  • getProxyChildSettings函数中,错误信息err = fmt.Errorf("set proxy method through gsettings failed")应更具体,以清晰表达未成功设置代理方法的原因。
  • setProxyMethod函数中,新增代码m.service.Emit(m, "ProxyMethodChanged", proxyMode)可能需要检查m.service是否为nil,以避免潜在的空指针异常。

是否建议立即修改:

@fly602
Copy link
Contributor Author

fly602 commented Jul 19, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 19, 2024

This pr cannot be merged! (status: unstable)

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit ff1521a into linuxdeepin:master Jul 19, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants