Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mainwindow hide when popup opens #944

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

asterwyx
Copy link
Contributor

MainWindow should not hide when popup opens and the focus is still on dock even if HideMode is AlwaysHide. Let popup block hiding of mainwindow.

Log: fix mainwindow hide when popup opens
Issue: linuxdeepin/developer-center#4970

@asterwyx
Copy link
Contributor Author

/integrate

Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#855
PrNumber: 855
PrBranch: auto-integration-7354585786

@tsic404
Copy link
Contributor

tsic404 commented Jan 3, 2024

不应该在 DockPopupWindow 的show,hide调用中去设置,应该在 showEvent 和 hideEvent 中,要不然没有从dock上隐藏,这个状态就会乱掉

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 4, 2024

TAG Bot

New tag: 6.0.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #943

MainWindow should not hide when popup opens and the focus is still
on dock even if HideMode is AlwaysHide. Let popup block hiding of
mainwindow.

Log: fix mainwindow hide when popup opens
Issue: linuxdeepin/developer-center#4970
@asterwyx asterwyx merged commit cf909cd into linuxdeepin:master Jan 4, 2024
18 checks passed
@asterwyx asterwyx deleted the popup branch January 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants