Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not able to rearrange item in fullscreen mode #354

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Jul 18, 2024

修复全屏模式无法拖放图标的问题,由 2182128 引入。

Log:

修复全屏模式无法拖放图标的问题,由 2182128 引入。

Log:
@BLumia BLumia requested a review from robertkill July 18, 2024 07:48
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中存在重复的DND相关函数定义,建议将它们提取到一个单独的函数或模块中,以提高代码的可维护性和可读性。
  • currentlyDraggedId 的赋值在 Drag.onActiveChanged 信号处理函数中可能不是线程安全的,需要确保在多线程环境下正确处理。
  • dropOnItemdropOnPage 函数中的日志信息应该使用日志库来记录,而不是直接打印在控制台上,以遵循项目的日志记录标准。
  • tryToRemoveEmptyPage 函数缺少注释说明其功能和用途,建议添加以提高代码的可读性。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, robertkill

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants