fix: 修复了代理与端口之间控件使用不对的问题 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
有线链接这个标题不在group里面，是并列的 |
|
好的 再改下 |
|
还是不太对。。group是把一组放到一起并且设置背景颜色。。它本身也可以被appendChild, 不要一股脑都加到group里面 另外记得是 |
|
1 2 有线连接是单独的child |
|
好的好的 |
|
commit 尽量用英文，当然也不强制，既然你修改了方案，那commit也要--amend修改，然后保存 另外调试的话，你可以编译安装最新的控制中心， dde-control-center --spec /dir/of/so这样会方便你调试。。我希望控制中心发版本后再解决这些插件的问题。。不过你现在已经在修改了。 控制中心的文档也还不全呢。。 |
|
确实，改起来也有点麻烦，我尽量再改，谢谢 |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Decodetalkers
requested changes
Apr 20, 2023
|
怎么又搞出了两个Commit，是Rebase不是merge啊 |
|
麻了，这个应该怎么撤回呢 |
|
你本地还是只有一个commit对吧，那就 |
LoserZzy
force-pushed
the
zzy_spacing
branch
3 times, most recently
from
f3d6c0b
to
2f143d1
Compare
|
你耐心等下吧，最近在做集成，下周再处理你们的pr |
|
好的好的，耽误了您的时间，谢谢指导 |
应用代理，网络详情页面的每一行间距过大，把间距改为1 issue: linuxdeepin#141 Log: 修复了代理与端口之间控件使用不对的问题
BLumia
requested review from
ComixHe and
18202781743
and removed request for
ComixHe
您好，请问现在能review了嘛 |
18202781743
approved these changes
Apr 25, 2023
|
/merge |
|
This pr cannot be merged! (status: blocked) |
Decodetalkers
approved these changes
Apr 25, 2023
|
/merge |
|
才发现修错了。。一个网络应该是一个systemgroup,现在都放到一个里面了。。我修下吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
系统代理，应用代理，网络详情页面的每一行间距过大，把间距改为1
issue: #141
Log: 修复了代理与端口之间控件使用不对的问题
修改前效果：
修改后效果：