Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modifying configuration errors can also set proxy issues #256

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

caixr23
Copy link
Contributor

@caixr23 caixr23 commented Jul 26, 2024

When configuring incorrectly, setting the proxy did not take effect, resulting in asynchronous network proxy status on the taskbar

Issue: linuxdeepin/developer-center#9983

When configuring incorrectly, setting the proxy did not take effect, resulting in asynchronous network proxy status on the taskbar

Issue: linuxdeepin/developer-center#9983
yixinshark
yixinshark previously approved these changes Jul 26, 2024
bump to version 2.0.31

Log: bump to version 2.0.31
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SysProxyModule::SysProxyModule构造函数中,新增的checkConf()函数调用可能需要检查m_proxyTypeBoxm_buttonTuple是否为空,以避免潜在的空指针异常。
  • SysProxyModule::checkConf函数中,应该检查m_proxyTypeBox->comboBox()->currentIndex()是否为有效的索引,以避免潜在的数组越界访问。
  • SysProxyModule::eventFilter函数中,应该添加对event->type() == QEvent::FocusIn的判断,以避免在编辑框获得焦点时重复调用checkConf()
  • SysProxyModule::resetData函数中,应该添加对uiMethodChanged的调用,以便在设置代理方法时更新界面。
  • SysProxyModule::deactive函数中,新增的QTimer::singleShot调用应该传递一个lambda函数,而不是直接传递一个匿名函数,以避免潜在的内存泄漏。

是否建议立即修改:

Copy link

TAG Bot

TAG: 2.0.31
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark
Copy link
Contributor

/topic shell-testing-20240724

@deepin-ci-robot
Copy link

Add topic: shell-testing-20240724 successed.

@yixinshark
Copy link
Contributor

/integr-topic shell-testing-20240724

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1788

@caixr23
Copy link
Contributor Author

caixr23 commented Jul 26, 2024

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 26, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit b6892e8 into linuxdeepin:master Jul 26, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants