Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Save button is not enabled when proxy address changed after saving #265

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ArchieMeng
Copy link
Contributor

Bug: https://pms.uniontech.com/bug-view-273365.html
Log: Save button is not enabled when proxy address changed after saving

Bug: https://pms.uniontech.com/bug-view-273365.html
Log: Save button is not enabled when proxy address changed after saving
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SysProxyModule::initManualView函数中,新增的connect信号槽连接可能存在潜在的槽函数错误。应该检查proxyEdit->textEdit()是否确实拥有textChanged信号。
  • SysProxyModule::initManualView函数中,新增的槽函数没有处理text为空的情况,可能会导致m_buttonTuple->setEnabled(true);在不需要时被触发。
  • connect槽函数中,直接使用this指针作为槽函数的参数,可能会导致隐式转换为QObject *,这可能不是预期的行为,应该使用static_cast进行显式类型转换。
  • m_ignoreListtextChanged信号与槽函数的连接方式与之前的代码风格不一致,建议统一信号槽的连接方式。
  • m_ignoreList的信号槽连接没有处理text为空的情况,应该添加对空文本的检查。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 11, 2024

TAG Bot

New tag: 2.0.33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #264

@ArchieMeng
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 58dcb07 into linuxdeepin:master Sep 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants