Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dock or undock abnormal function #546

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

yixinshark
Copy link
Contributor

as title

Log: as title
Influence: dock or undock function

as title

Log: as title
Influence: dock or undock function
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • setItemOnDock 函数中的参数名从 itemKey 更改为 surfaceId,需要确认这一更改是否已在所有调用此函数的地方实施。
  • 移除了 pluginId 的获取逻辑,如果 itemKey 对应多个插件,这将导致 surfaceId 包含多个插件的 ID,可能会影响设置和移除逻辑的预期行为。

是否建议立即修改:

  • 是,需要确保 surfaceId 的更改不会影响现有功能,并且与整个项目的命名约定一致。同时,应该验证移除 pluginId 获取逻辑的影响,并确保相关功能仍然按预期工作。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants