Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: large radius when exist scaling #581

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

18202781743
Copy link
Contributor

scaling has been processed in kwin for 1070.

Issue: linuxdeepin/developer-center#9818

@18202781743
Copy link
Contributor Author

18202781743 commented Jul 23, 2024

linuxdeepin/developer-center#9727 此问题在缩放下也受影响,

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

TAG Bot

New tag: 0.0.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #572

scaling has been processed in kwin for 1070.

Issue: 	linuxdeepin/developer-center#9818
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • PanelPopupWindow.qml中,移除了D.DWindow.windowRadiusScreen.devicePixelRatio的乘积,可能会影响窗口圆角的显示效果。
  • PanelToolTipWindow.qml中,将D.DWindow.windowRadius的值从4 * Screen.devicePixelRatio直接改为4,需要确认这是否是预期的更改,因为圆角大小应该根据屏幕像素比进行调整。

是否建议立即修改:

  • 是,需要确认圆角大小的更改是否符合设计要求,并确保这一更改不会影响用户界面的一致性和可用性。如果更改是故意的,应该在代码中添加注释说明原因。如果这是一个错误,应该恢复原来的代码。

@18202781743
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 7b93db4 into linuxdeepin:master Jul 23, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants