Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workSpace toolTip text error #588

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jul 23, 2024

workSpace toolTip text error

Issue: linuxdeepin/developer-center#9877

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • onEntered信号处理函数中,toolTip.text的赋值逻辑可能不正确,因为content.workspaceName可能不是字符串类型。
  • toolTip.DockPanelPositioner.bounding的赋值逻辑可能会导致tooltip位置不正确,因为point.xpoint.y的值可能不是整数。
  • toolTip.open()函数调用可能需要检查toolTip对象是否已经创建和配置。

是否建议立即修改:

@18202781743
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit cd66584 into linuxdeepin:master Jul 23, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants