Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the issue of the settings window #489

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

pengfeixx
Copy link
Contributor

Fixed the issue of the settings window

Log: Fixed the issue of the settings window

Fixed the issue of the settings window

Log: Fixed the issue of the settings window
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了DialogTitleBar的配置项enableInWindowBlendBlur,需要确认是否有其他代码或配置与之关联,以避免潜在的功能缺失。
  • 代码中没有新增的注释来解释为什么移除了DialogTitleBar的相关配置,这可能会影响代码的可维护性。

是否建议立即修改:

  • 是,建议添加相应的注释来解释移除配置的原因,并确保相关功能不会受到影响。如果enableInWindowBlendBlur的移除是有意为之,应该在代码中添加相应的注释来解释为什么这样做。如果这是一个无意的移除,应该立即恢复该配置。

@jeffshuai
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 24, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 7b7ec51 into linuxdeepin:master Sep 24, 2024
15 of 17 checks passed
@pengfeixx pengfeixx deleted the setting branch September 24, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants