Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimize command line acquisition parameters #540

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

lzwind
Copy link
Contributor

@lzwind lzwind commented Sep 12, 2024

Optimize command line acquisition parameters

Log: Optimize command line acquisition parameters
Task: https://pms.uniontech.com/task-view-362613.html

Optimize command line acquisition parameters

Log: Optimize command line acquisition parameters
Task: https://pms.uniontech.com/task-view-362613.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • checkCpuIsZhaoxin函数中,使用QStringList来存储命令选项可能导致不必要的内存分配和性能下降。建议使用QVector<QString>来存储选项。
  • currentAudioChannel函数中,对targetLine的处理应该在循环结束后进行,而不是在每次迭代时。
  • getProductType函数中,使用QString(QLatin1String(tempArray.data()))来转换输出数据可能不是最安全的做法,应该检查数据的编码和长度。
  • WaylandIntegration::getProductType函数中,直接使用awk命令可能不适用于所有环境,应该检查是否需要指定特定的awk选项。
  • dmidecode命令中,直接使用grep可能不会按预期工作,应该检查是否需要指定grep-i选项。

是否建议立即修改:

@lzwind
Copy link
Contributor Author

lzwind commented Sep 12, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 12, 2024

This pr cannot be merged! (status: blocked)

@lzwind
Copy link
Contributor Author

lzwind commented Sep 24, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 24, 2024

This pr cannot be merged! (status: blocked)

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
Copy link
Contributor Author

lzwind commented Sep 24, 2024

/merge

@deepin-bot deepin-bot bot merged commit 732c3c6 into linuxdeepin:release/eagle Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants