Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkgui #49

Merged
merged 1 commit into from
Jul 8, 2024
Merged

sync: from linuxdeepin/dtkgui #49

merged 1 commit into from
Jul 8, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#244

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#244
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DDciIconPrivate::paint函数中,直接使用layer对象绘制,跳过了缩放步骤,可能影响图标的大小和显示质量。
  • writeScaledImage函数中,sizeDir.toInt(&ok)可能会导致异常,如果sizeDir不能转换为整数,ok将为false,但代码没有处理这种情况。
  • a.setApplicationVersion("0.0.6")中的版本号更新应该确保与实际版本号一致,避免混淆或错误。

是否建议立即修改:

@kegechen kegechen merged commit 86041c6 into master Jul 8, 2024
11 of 13 checks passed
@kegechen kegechen deleted the sync-pr-244-nosync branch July 8, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants