Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#597

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#597
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DIndeterminateProgressbarPrivate构造函数中,m_animation初始化时未设置目标对象,可能导致行为异常。
  • DSearchEditPrivate::_q_toEditMode方法中的动画控制逻辑可能存在逻辑错误,特别是在设置动画方向时。
  • DSearchEditPrivate::_q_toEditMode方法中的if (!q->lineEdit()->text().isEmpty())判断可能是不必要的,因为当文本不为空时,方法已经返回。
  • DSearchEditPrivate::_q_onVoiceActionTrigger方法中的if (animation->state() == QPropertyAnimation::Running)判断可能不会按预期工作,因为animation->state()可能不是只读的。
  • DSearchEditPrivate::_q_onVoiceActionTrigger方法中的iconWidget->move(QPoint(q->lineEdit()->geometry().center().x() - iconWidget->width() / 2, iconWidget->pos().y()));可能会导致iconWidget在父布局中位置不正确。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant