Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#608

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#608
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DBounceAnimation::eventFilter函数中,对wheelEvent->pixelDelta().x()的判断逻辑可能不正确,因为pixelDelta表示的是两次鼠标移动的像素差,而wheelEvent->angleDelta().x()表示的是滚轮滚动的角度。应该使用wheelEvent->pixelDelta().y()来判断滚动方向。
  • ImageLabel类的drawPixmap方法中,使用pixmap(Qt::ReturnByValue)可能会导致不必要的内存分配和上下文切换,建议使用pixmapcopy方法来避免这个问题。
  • DSwitchButton类的paintEvent方法中,新增的代码块可能会导致按钮状态的多次更新,建议检查是否有必要更新状态。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant