Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add nullptr check #423

Merged
merged 1 commit into from
May 30, 2024
Merged

chore: add nullptr check #423

merged 1 commit into from
May 30, 2024

Conversation

kegechen
Copy link
Contributor

nullptr check

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在else if语句中,条件判断逻辑可能存在问题。原代码中是检查m_fallbackConfig是否存在,而修改后的代码是检查m_dsgConfig是否存在,这可能会导致不同的行为。
  • 代码修改后,如果m_dsgConfig存在但未设置RULES_KEY的值,var可能会是nullptr,这可能不是预期的行为。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 30, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#423
@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 30, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 6f02ee5 into linuxdeepin:master May 30, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants