Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use '&&' and '||' instead of 'and' and 'or' #426

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

zsien
Copy link
Member

@zsien zsien commented Jun 7, 2024

一些项目使用了 -fno-operator-names,会导致编译失败

一些项目使用了 -fno-operator-names,会导致编译失败
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • unescapeFromObjectPath函数中,修改了条件判断语句,增加了括号以避免歧义。
  • getAppIdFromAbsolutePath函数中,移除了不必要的空格,使代码更紧凑。

是否建议立即修改:

  • 否,这次提交的修改主要是风格和格式上的,没有改变代码的逻辑。因此,如果没有其他的代码质量或功能性问题,这些修改可以不用立即进行。不过,保持代码风格的一致性是一个好习惯,可以在下一次代码提交时包含这些风格上的改动。

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jun 7, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#426
@zsien zsien requested review from kegechen and ComixHe June 7, 2024 07:37
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComixHe, kegechen, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 7, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@zsien
Copy link
Member Author

zsien commented Jun 7, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 7, 2024

This pr cannot be merged! (status: unstable)

@kegechen kegechen merged commit a1add00 into linuxdeepin:master Jun 7, 2024
19 of 21 checks passed
@zsien zsien deleted the zs/fix/operator-names branch June 7, 2024 07:43
kegechen pushed a commit to linuxdeepin/dtk6core that referenced this pull request Jun 18, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants