Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to 5.6.31 #427

Closed
wants to merge 1 commit into from

Conversation

zsien
Copy link
Member

@zsien zsien commented Jun 17, 2024

  • chore: use '&&' and '||' instead of 'and' and 'or'

  * chore: use '&&' and '||' instead of 'and' and 'or'
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在debian/changelog文件中,版本号更新从5.6.30到5.6.31,确认是否有相应的代码提交和功能变更来支持这一版本更新。
  • 代码风格的一致性:检查是否有其他地方也使用了'and'和'or',确保整个项目中风格的一致性。
  • 代码注释:确认是否有必要的注释来解释为什么使用'&&'和'||'替换'and'和'or',以及这样的替换是否会影响代码的功能。

是否建议立即修改:

  • 是,需要确保版本号的更新与代码提交的一致性,并保持代码风格的一致性。同时,应该有充分的理由和注释来支持代码风格的更改。

@zsien
Copy link
Member Author

zsien commented Jun 17, 2024

/add-toppic dccim

Copy link

TAG Bot

TAG: 5.6.31
EXISTED: no
DISTRIBUTION: unstable

@zsien
Copy link
Member Author

zsien commented Jun 17, 2024

/topic dccim

@deepin-ci-robot
Copy link
Contributor

Add topic: dccim successed.

@zsien
Copy link
Member Author

zsien commented Jun 17, 2024

/integr-topic dccim

@deepin-ci-robot
Copy link
Contributor

Integrated with pr deepin-community/Repository-Integration#1608

Copy link
Contributor

@kegechen kegechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dtk 集成单独走,或者把dtkgui/dtkwidget/dtkdeclarative/qt5integration 等一起集成

@kegechen kegechen closed this Jun 25, 2024
@kegechen
Copy link
Contributor

see: #428

@zsien zsien deleted the zs/chore/newversion branch June 25, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants