Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade haml and sass #391

Merged
merged 3 commits into from
Apr 14, 2024
Merged

Upgrade haml and sass #391

merged 3 commits into from
Apr 14, 2024

Conversation

echarp
Copy link
Member

@echarp echarp commented Apr 1, 2024

Les 2 librairies haml et sass étaient bloquées sur d'anciennes versions.

Pour la migration il a fallu notamment ajouter une fonction list_of qui n'est plus gérée dans la librairie haml.

Pour sass un fichier parts/_variables.scss a été créé.

La nouvelle version supprime quelques helper, dont `list_of` qui était
utilisée ici et là et qui est maintenant rajoutée dans
`application_helper`.

Méthodes supprimées:
  block_is_haml?, capture_haml, escape_once, find_and_preserve, flatten, haml_concat,
  haml_indent, haml_tag, haml_tag_if, html_attrs, html_escape, init_haml_helpers, is_haml?,
  list_of, non_haml, precede, succeed, surround, tab_down, tab_up, with_tabs

Référence: https://github.com/haml/haml/releases/tag/v6.0.0
Still maintained, will require an upgrade to dart-sass at some point.
@Trim
Copy link
Member

Trim commented Apr 14, 2024

Merci ! 👍

@Trim Trim merged commit e718ec1 into linuxfrorg:rails7 Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants