Update packages to use alpine base (plus other cleanups) #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added packages are necessary to create a base Alpine container image and for converting more packages. Update the versions file to the latest versions Also make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
Also make the HUB org/registry build time configurable for these packages. Others will be reworked in sub sequent commits. Signed-off-by: Rolf Neugebauer <[email protected]>
We only need the alpine-baselayout packe to run init. This also removes the sha256 import from alpine:edge. This also reduces the size of the init package by more than 50% to just 1.5MB. Also make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
The dhcpcd package only needs a basic alpine-baselayout and dhcpcd. This reduces the size of the package from 4.3MB to 1.8MB. Also make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
Also make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
Also make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
Also make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
Also make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
Also convert to a multi-stage build and make the make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
Also convert it to a multi-stage build and make the HUB org/registry build time configurable. Signed-off-by: Rolf Neugebauer <[email protected]>
This makes the package slightly bigger as tini from Alpine is not statically linked but removes the dependency on ./tools/tini Signed-off-by: Rolf Neugebauer <[email protected]>
Signed-off-by: Rolf Neugebauer <[email protected]>
All users in ./pkg and ./test have been converted to use tini from the alpine base image. Signed-off-by: Rolf Neugebauer <[email protected]>
You cna extract/inspect the contents with 'docker save' + 'tar' Signed-off-by: Rolf Neugebauer <[email protected]>
Signed-off-by: Rolf Neugebauer <[email protected]>
Update the Makefiles of the remaining packages. Signed-off-by: Rolf Neugebauer <[email protected]>
Signed-off-by: Rolf Neugebauer <[email protected]>
| RUN apk add --no-cache --initdb -p /out alpine-baselayout busybox musl | ||
|
|
||
| # Remove apk residuals. We have a read-only rootfs, so apk is of no use. | ||
| RUN rm -rf /out/etc/apk /out/lib/apk /out/var/cache |
There was a problem hiding this comment.
actually init is where I still sometimes use apk add for debug (you can remount rw), but I guess we should get rid of these now...
There was a problem hiding this comment.
hopefully soon we have a dev container in which we should maybe not disabled apk
justincormack
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alpine:3.5or other to use thelinuxkit/alpineas the base/outand then copy them into ascratchstagealpine:edgecomes with tini, so switch packages to use that and remove our home-build tini packagemake ... ORG=foo(resolves Set docker hub repository linuxkit as variable #1824)I've test this with the
linuxkitanddockerimages and hyperkit and qemu