Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace switcher: Add option to display windows icons #11530

Closed
wants to merge 32 commits into from
Closed

workspace switcher: Add option to display windows icons #11530

wants to merge 32 commits into from

Commits on Jan 4, 2024

  1. feat: icon display for the workspace-switcher applet initial implemen… 

    …tation
    @anaximeno
    anaximeno committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1d86985 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. feat: initial implementation of workspace window icon graph button

    @anaximeno
    anaximeno committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    ad0c320 View commit details
    Browse the repository at this point in the history

  2. fix: focus issue on a new workspace

    @anaximeno
    anaximeno committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c5d789b View commit details
    Browse the repository at this point in the history

  3. perf: use just one filter routine

    @anaximeno
    anaximeno committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    ed5cf9d View commit details
    Browse the repository at this point in the history

  4. chore: cleanup

    @anaximeno
    anaximeno committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    97792fa View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. feat: show icon according to the position of the window 

    This is not perfect yet. I have yet to handle some cases:
1. When the window is moved to an area close to the borders of the workspace representation,
2. Improve the position of the icon to be centered according to the size of the window representation,
3. Move the icon to the remaining position if there are any when the window is moved to a position close to the border
    @anaximeno
    anaximeno committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    61ed422 View commit details
    Browse the repository at this point in the history

  2. chore: center icon

    @anaximeno
    anaximeno committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    e689fd7 View commit details
    Browse the repository at this point in the history

  3. chore: adapt settings for the new workspace representation type

    @anaximeno
    anaximeno committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    e1acfab View commit details
    Browse the repository at this point in the history

  4. chore: properly destroy unneeded WindowIconGraph references

    @anaximeno
    anaximeno committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    22a9501 View commit details
    Browse the repository at this point in the history

  5. refactor: simplify algorithm and fixed the focus issue

    @anaximeno
    anaximeno committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    5ce7bf0 View commit details
    Browse the repository at this point in the history

  6. refactor: made a bit of refactoring

    @anaximeno
    anaximeno committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    d6cd9d5 View commit details
    Browse the repository at this point in the history

  7. perf: only update focus window on position and size changed signals

    @anaximeno
    anaximeno committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    aae6014 View commit details
    Browse the repository at this point in the history

  8. refactor: set the window icon graph as a addition to the workspace graph 

    This way we avoid code duplication and simplify the settings to activate this option, since the user will easilly see the option to activate and deactivate the window icons option
    @anaximeno
    anaximeno committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    ec95395 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. chore: update positioning of the icon

    @anaximeno
    anaximeno committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    e54b76e View commit details
    Browse the repository at this point in the history

  2. chore: completelly fix the icon positioning problem 

    Now it will center the icon according to the intersected rectangle between the scaled window rectangle and the workspace graph. Had to use a bit of my geometry knowledge :)
    @anaximeno
    anaximeno committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    f5b041f View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. perf: draw only the intersection intead of the whole window rect

    @anaximeno
    anaximeno committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    55fc2a6 View commit details
    Browse the repository at this point in the history

  2. chore: dont set the size of the window bin actor

    @anaximeno
    anaximeno committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6334bc0 View commit details
    Browse the repository at this point in the history

  3. chore: removed unused attribute

    @anaximeno
    anaximeno committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4fb5c15 View commit details
    Browse the repository at this point in the history

  4. refactor: directly set the icon position after painting 

    This may also be more performant as we will calculate the intersection rect only once
    @anaximeno
    anaximeno committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    bd31a07 View commit details
    Browse the repository at this point in the history

  5. chore: remove padding 

    It is not necessary
    @anaximeno
    anaximeno committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    de247b8 View commit details
    Browse the repository at this point in the history

  6. feat: make the icon size configurable

    @anaximeno
    anaximeno committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    48d385c View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. feat: remove non necessary bin actor

    @anaximeno
    anaximeno committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    7caa2ce View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. refactor: made some refactoring

    @anaximeno
    anaximeno committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    ebec2cf View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. refactor: made small updates to the code

    @anaximeno
    anaximeno committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    8184a44 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. chore: round intersection rect values

    @anaximeno
    anaximeno committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    af54c73 View commit details
    Browse the repository at this point in the history

  2. chore: update window icon size limit to 32px

    @anaximeno
    anaximeno committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    8f882c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. refactor: Made some refactoring 

    chore: Improve focus window update
    @anaximeno
    anaximeno committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f0dfd1d View commit details
    Browse the repository at this point in the history

  2. chore: Improve settings text

    @anaximeno
    anaximeno committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    fff1f42 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. chore: Add tooltip regarding bluriness depending on the size

    @anaximeno
    anaximeno committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d9a4b65 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'master' into feat/workspace-switcher/show-window-icon

    @anaximeno
    anaximeno committed May 17, 2024
    Configuration menu
    Copy the full SHA
    59faf0b View commit details
    Browse the repository at this point in the history

  2. refactor: Made a small refactoring

    @anaximeno
    anaximeno committed May 17, 2024
    Configuration menu
    Copy the full SHA
    abb0ce8 View commit details
    Browse the repository at this point in the history

  3. chore: Update window graph get icon method

    @anaximeno
    anaximeno committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e77e3ac View commit details
    Browse the repository at this point in the history