Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show panel if a menu is open on it #11779

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Gr3q
Copy link
Contributor

@Gr3q Gr3q commented Jul 24, 2023

instead of the current policy of "Don't hide the panel if a menu is open on it". With this, if you open an applet with a keybinding, the panel for it will also show.

I made these changes for another PR, so I thought I open it. Discuss it among yourselves if it's really needed.

Maybe it can be turned into an optional toggle (feature) turning this change into a conditional.

Gr3q added 4 commits July 21, 2023 20:03
…to auto hide

The problem is that the panel reports it's not visible even though it is,
so the  x,y calculation for PopupMenus are incorrect.

Panels are not hidden until `global.menuStackLength` is bigger than one
(meaning a PopupMenu is open for example)
@Gr3q Gr3q changed the title Always show panel if a menu open on it Always show panel if a menu is open on it Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant