Menu applet: Fix bug where menu is partly behind panel #11788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call peekPanel() before toggling menu open to ensure menu is positioned correctly.
this._shouldShow is set to false when mouse leaves auto-hide panel even if panel remains open due to an applet being open so use !this._hidden instead.
|
Replaces PR #11770 |
mtwebster
pushed a commit
that referenced
this pull request
Aug 20, 2023
* Fix bug where menu is partly behind panel Call peekPanel() before toggling menu open to ensure menu is positioned correctly. * panel.js: Use better method to determine when panel is visible. this._shouldShow is set to false when mouse leaves auto-hide panel even if panel remains open due to an applet being open so use !this._hidden instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more accurate method to determine when panel is visible in panel.js
Call peekPanel() before toggling menu open to ensure menu is positioned correctly.
_updateKeybinding() is also the correct place to call peekPanel() anyway because it's only needed when menu is opened with key-press.
Fixes #10970, #11035, #11429, #11547, linuxmint/mint21.2-beta#49
Fixes linuxmint/cinnamon-spices-applets#4964