Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dual batteries properly in Power Management / Cinnamon Settings #11790

Closed
wants to merge 2 commits into from

Conversation

libf-de
Copy link
Contributor

@libf-de libf-de commented Jul 25, 2023

I'm using Cinnamon on a ThinkPad T480 with dual batteries. Currently both batteries are shown in the panel applet, but only the internal one is shown in power management:
grafik

The reason for that is, as mentioned in #7745, that additional batteries are only shown if they are fully charged or empty. I see no point doing it like that. Adding the other charging states:
grafik

Now it's visible, but no percentage and it's impossible to rename it. Also can't see the point for doing it like this. So, after making every battery a "primary battery":
grafik

I've also added "PENDING_CHARGE" and "PENDING_DISCHARGE" as separate states, so it's possible to differentiate which battery is in use / being charged. Those will need translations.

@mtwebster
Copy link
Member

mtwebster commented Jul 31, 2023

Can we leave out the Not Charging/Discharging change for now? We'd have to wait on translations, and typically wouldn't do it until the end of the next development cycle. If we hold off on that change I can merge it now, and we can address it later on.

Thanks

edit: by the way, what theme is that? It's kind of nice.

@libf-de
Copy link
Contributor Author

libf-de commented Aug 2, 2023

Of course, can you just merge the single commit, or should I open another pull request?

The theme is Orchis-dark: https://github.com/vinceliuice/Orchis-theme

@mtwebster
Copy link
Member

Ok merged the one commit - b7f958e

I'll leave this open until I get the other one in.

Thanks

@mtwebster mtwebster added the Blocked Needs rebase, changes, or discussion label Aug 7, 2023
@mtwebster mtwebster removed the Blocked Needs rebase, changes, or discussion label Apr 5, 2024
@mtwebster
Copy link
Member

I had the additional commit in my local repo still.

8214ed1

Thanks

@mtwebster mtwebster closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants