Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inhibit applet - Allow power management inhibition on startup #12061

Conversation

claudiux
Copy link
Member

Adds an option to the settings to enable inhibition of power management on start-up.

@rcalixte rcalixte self-requested a review January 31, 2024 18:02
@rcalixte
Copy link
Member

Coding-wise, it works. One issue I see is that this has a conflict with #11744. I'll leave it up to others if this should be merged or not though.

@claudiux claudiux force-pushed the inhibit-applet_allow-inhibition-at-startup branch from aa73769 to 79a12b8 Compare January 31, 2024 18:10
@claudiux
Copy link
Member Author

@rcalixte This applet already lets you disable notifications.

@rcalixte
Copy link
Member

@rcalixte This applet already lets you disable notifications.

Hmm? I'm not sure I understand.

@claudiux
Copy link
Member Author

claudiux commented Feb 1, 2024

@rcalixte I'm the one who didn't understand. In this PR, I'll take your changes into account.

@claudiux claudiux marked this pull request as draft February 1, 2024 22:00
@claudiux
Copy link
Member Author

claudiux commented Feb 1, 2024

@rcalixte
Your changes have been taken into account. That works well, good job!
I think there should be a specific icon when both are disabled.
Would you like me to do the same for notifications (ability to disable at startup)?

@claudiux claudiux marked this pull request as ready for review February 1, 2024 22:35
@rcalixte
Copy link
Member

rcalixte commented Feb 1, 2024

Your changes have been taken into account. That works well, good job!

I don't think that's what should have been done. That PR is still waiting on review and final feedback. You should be avoiding a conflict with that not creating one. Your proposed change and the changes in the already open PR should be independent and as conflict-free as possible.

I think there should be a specific icon when both are disabled.

There already is. I've been running this locally for months.

Would you like me to do the same for notifications (ability to disable at startup)?

There is no need for this. Notifications are disabled via gsettings which are not reset on Cinnamon restarts or system reboots.

Copy link
Member

@rcalixte rcalixte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the other PR's proposed changes and try to avoid a conflict with that branch if possible.

@rcalixte
Copy link
Member

rcalixte commented Feb 1, 2024

@claudiux You have the ability to communicate with me directly. Instead of operating on your own in a state of confusion, I implore you to make use of that so that these situations can be avoided in the future. Two minutes of conversation would have prevented hours of wasted time. If this isn't agreeable, please let me know and we can find another solution that works for you. This current state of affairs is not good.

@claudiux claudiux marked this pull request as draft February 2, 2024 07:22
@claudiux claudiux closed this Feb 11, 2024
@claudiux claudiux deleted the inhibit-applet_allow-inhibition-at-startup branch February 11, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants