-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inhibit applet - Allow power management inhibition on startup #12061
inhibit applet - Allow power management inhibition on startup #12061
Conversation
files/usr/share/cinnamon/applets/[email protected]/settings-schema.json
Outdated
Show resolved
Hide resolved
Coding-wise, it works. One issue I see is that this has a conflict with #11744. I'll leave it up to others if this should be merged or not though. |
aa73769
to
79a12b8
Compare
@rcalixte This applet already lets you disable notifications. |
Hmm? I'm not sure I understand. |
@rcalixte I'm the one who didn't understand. In this PR, I'll take your changes into account. |
@rcalixte |
I don't think that's what should have been done. That PR is still waiting on review and final feedback. You should be avoiding a conflict with that not creating one. Your proposed change and the changes in the already open PR should be independent and as conflict-free as possible.
There already is. I've been running this locally for months.
There is no need for this. Notifications are disabled via gsettings which are not reset on Cinnamon restarts or system reboots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the other PR's proposed changes and try to avoid a conflict with that branch if possible.
@claudiux You have the ability to communicate with me directly. Instead of operating on your own in a state of confusion, I implore you to make use of that so that these situations can be avoided in the future. Two minutes of conversation would have prevented hours of wasted time. If this isn't agreeable, please let me know and we can find another solution that works for you. This current state of affairs is not good. |
Adds an option to the settings to enable inhibition of power management on start-up.