Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automated release workflow #372

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

Joshua-Dickens
Copy link
Member

@Joshua-Dickens Joshua-Dickens commented Jun 15, 2023

Cleaned up checksum generation, got rid of old soon to be deprecated set_output styling for the new styling recommended by github, and small formatting changes that should make the autogenerated release text cleaner.

Copy link
Member

@whot whot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joshua-Dickens can you fix your editor please so git commit messages don't exceed 78 characters? I think that's a requirement for most projects anyway (and it improves readability).

other than that, this LGTM, thanks!

@whot
Copy link
Member

whot commented Jun 22, 2023

the checkpatch job should be taught to ignore commits that don't touch the kernel directories...

@Joshua-Dickens
Copy link
Member Author

@whot
Fixed my editor, don't know why I haven't done it before since it'll help with me forgetting commit formatting. As for the checkpatch that's something we can look into, I took a quick peek at the config options for the action we're using and I don't see anything in there that might help with that so we'll have to add some logic to the workflow itself. Something I can look into knocking out.

@whot
Copy link
Member

whot commented Jun 27, 2023

quick google found this link - since we have checkpatch as a separate workflow already it seems like it's just a matter of adding paths to the top-level on

Cleaned up checksum generation, got rid of old soon to be deprecated
set_output styling for the new styling recommended by github, and small
formatting changes that should make the autogenerated release text cleaner.

Signed-off-by: Joshua Dickens <[email protected]>
@Joshua-Dickens
Copy link
Member Author

Yeah that seems like it would do the trick.
Went ahead and rewrote the commit message to make it a bit cleaner and with that this merge should be good.

@Joshua-Dickens Joshua-Dickens merged commit 84a5990 into linuxwacom:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants