Import w8001 patch from upstream #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Signed-off-by: Wolfram Sang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Torokhov <[email protected]> [[email protected]: Imported into input-wacom (a9f08ad7adb3) Signed-off-by: Jason Gerecke <[email protected]>
…arning Commit a9f08ad7adb3 upstream introduces an unused-result warning. While we wait for a fix to be made upstream, this commit has our Github runner not treat the warning as an error. This will need to be reverted after a fix is accepted upstream. Signed-off-by: Jason Gerecke <[email protected]>
|
Patchset looks good to me. We'll work on the mentioned upstream patch and come back to clean up this repo when that patch is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports the following upstream commit:
Input: move from strlcpy with unused retval to strscpy(a9f08ad7adb3). The strlcpy function is removed in Linux 6.9, which prevents input-wacom from compiling without this commit. The import only applies to the 4.5 branch since strscpy is not available in 3.17.This request also includes a commit to (temporarily) set
-Wno-error=unused-resultwhen Github runs its compile tests. This is because the new strscpy function has a return value which is currently ignored. We should fix this upstream and then revert this second change once it is no longer needed.