Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to Node.js 22 TDE-1193 #1003

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: update to Node.js 22 TDE-1193 #1003

wants to merge 1 commit into from

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jun 3, 2024

Motivation

Keep our software up to date, and get any useful features, fixes, and
optimisations from new versions of dependencies.

Modification

  1. Update the engine:

    jq '.engines.node = "^22.11.0"' package.json | sponge package.json
    
  2. Update the uses of linz/action-typescript:

    for path in .github/workflows/*.y*ml; do
        yq --inplace '(.jobs.*.steps[] | select(.uses == "linz/action-typescript*").with.node-version) = "22.x"' "$path"
    done
    
  3. Update Dockerfile manifest digest:

    sed --in-place --expression="s/^FROM node:.*/FROM node:22-slim@$(docker manifest inspect node:22-slim | jq --raw-output '.manifests[] | select(.platform.architecture == "amd64" and .platform.os == "linux") | .digest')/" Dockerfile
    
  4. Verify the change:

    git clean -fdx --exclude=.idea
    npm install
    npm run build
    npm run test
    npm run docs
    npm run lint
    git grep --word-regexp -e 14 -e 16 -e 18 -e 20
    

Checklist

  • Tests updated (N/A)
  • Docs updated (N/A)
  • Issue linked in Title

package.json Show resolved Hide resolved
l0b0 added a commit that referenced this pull request Jun 20, 2024
@l0b0 l0b0 requested a review from blacha June 20, 2024 21:36
l0b0 added a commit that referenced this pull request Jun 20, 2024
@l0b0 l0b0 marked this pull request as draft September 6, 2024 04:00
auto-merge was automatically disabled September 6, 2024 04:00

Pull request was converted to draft

Copy link
Collaborator

@paulfouquet paulfouquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to lock to the latest?

@l0b0 l0b0 force-pushed the build/node-22 branch 2 times, most recently from 6a1ae62 to 020d2a1 Compare November 10, 2024 20:48
@l0b0 l0b0 marked this pull request as ready for review November 10, 2024 20:48
@l0b0 l0b0 enabled auto-merge November 10, 2024 20:48
Keep our software up to date, and get any useful features, fixes, and
optimisations from new versions of dependencies.

1. Update the engine:

   ```
   jq '.engines.node = "^22.11.0"' package.json | sponge package.json
   ```
2. Update the uses of `linz/action-typescript`:

   ```
   for path in .github/workflows/*.y*ml; do
       yq --inplace '(.jobs.*.steps[] | select(.uses == "linz/action-typescript*").with.node-version) = "22.x"' "$path"
   done
   ```
3. Update Dockerfile manifest digest:

   ```
   sed --in-place --expression="s/^FROM node:.*/FROM node:22-slim@$(docker manifest inspect node:22-slim | jq --raw-output '.manifests[] | select(.platform.architecture == "amd64" and .platform.os == "linux") | .digest')/" Dockerfile
   ```
4. Verify the change:

   ```
   git clean -fdx --exclude=.idea
   npm install
   npm run build
   npm run test
   npm run docs
   npm run lint
   ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants