generated from linz/template-javascript-hello-world
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to Node.js 22 TDE-1193 #1003
Open
l0b0
wants to merge
1
commit into
master
Choose a base branch
from
build/node-22
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Jun 20, 2024
l0b0
added a commit
that referenced
this pull request
Jun 20, 2024
l0b0
added a commit
that referenced
this pull request
Jun 20, 2024
auto-merge was automatically disabled
September 6, 2024 04:00
Pull request was converted to draft
paulfouquet
approved these changes
Nov 10, 2024
paulfouquet
requested changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to lock to the latest?
l0b0
force-pushed
the
build/node-22
branch
2 times, most recently
from
November 10, 2024 20:48
6a1ae62
to
020d2a1
Compare
l0b0
commented
Nov 10, 2024
Keep our software up to date, and get any useful features, fixes, and optimisations from new versions of dependencies. 1. Update the engine: ``` jq '.engines.node = "^22.11.0"' package.json | sponge package.json ``` 2. Update the uses of `linz/action-typescript`: ``` for path in .github/workflows/*.y*ml; do yq --inplace '(.jobs.*.steps[] | select(.uses == "linz/action-typescript*").with.node-version) = "22.x"' "$path" done ``` 3. Update Dockerfile manifest digest: ``` sed --in-place --expression="s/^FROM node:.*/FROM node:22-slim@$(docker manifest inspect node:22-slim | jq --raw-output '.manifests[] | select(.platform.architecture == "amd64" and .platform.os == "linux") | .digest')/" Dockerfile ``` 4. Verify the change: ``` git clean -fdx --exclude=.idea npm install npm run build npm run test npm run docs npm run lint ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep our software up to date, and get any useful features, fixes, and
optimisations from new versions of dependencies.
Modification
Update the engine:
Update the uses of
linz/action-typescript
:Update Dockerfile manifest digest:
Verify the change:
Checklist