Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send per queue metrics #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Send per queue metrics #3

wants to merge 3 commits into from

Conversation

Mongey
Copy link

@Mongey Mongey commented Nov 20, 2019

👋 This sends metrics about each queue's enqueued count.
Added the print so that you know the container is doing something when it boots, and also moved the sleep to the end of the loop, so that it sends metrics before it 😴

}

let mut total_enqueued = 0;
for (_queue_name, count) in enqueued_count_by_queue {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -98,9 +98,8 @@ fn main() {

let mut previous_total_processed: Option<u32> = None;

debug!("Welcome to datadog-sidekiq");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the usage of info! around the existing code base I could see this as info! as well (rather than debug!).

@lipanski
Copy link
Owner

thanks for your pull request and sorry for the long wait :)

I left a few comments. on top of that, could you also update the README.md (the Metrics section) please?

🥇

@PastorJordi
Copy link

I have been tagged in a "too good to be real" crypto scam. I cannot flag it, could you @lipanski, please? Else, delete it if possible
Thanks.
Happy new year, btw.

@lipanski
Copy link
Owner

lipanski commented Jan 2, 2024

@PastorJordi I'm not sure what you mean. Flag/delete what exactly?

@PastorJordi
Copy link

Sorry about annoying you.
The message has been removed already, so there's nothing else to do. The comment above mine was a crypto scam airdrop exploiting github mentions to bypass phishing filters (github replicates the comment content in an email while acting as a trusted sender hence the email renders perfectly in the recipient inbox)

see the screenshot attached
image
Cheers

@github-staff github-staff deleted a comment from knofte Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants