Delete unnecessary checks before some function calls #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on “free” The function “free” is documented in the way that no action shall occur for a passed null pointer. It is therefore not needed that a function caller repeats a corresponding check. https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first This issue was fixed by using the software “Coccinelle 1.1.1-00480-gd235ef51”. Signed-off-by: Markus Elfring <[email protected]>
…on “cd_delete” The function “cd_delete” of this software library tolerates also the passing of null pointers. It is therefore not needed that a function caller repeats a corresponding check. Signed-off-by: Markus Elfring <[email protected]>
|
Can you please add unit tests for these changes, just in case a later change breaks this behavior. |
|
Can you follow the desire for the avoidance of redundant checks before shown function calls? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redundant safety checks can be avoided.
It is therefore not needed that a function caller repeats a corresponding check.