[8381] add option to allow unregistered users to vote in polls

[goapunk]

Tasks

• PR name contains story or task reference
• Documentation (docs and inline)
• Tests (including n+1 and django_assert_num_queries where applicable)
• Changelog

[goapunk]

@m4ra @hom3mad3 here's a version where everything is integrated into the existing poll module for comparison. It's less big of a change than I expected. No changes are necessary on the a+ side so can be tested with main.

[m4ra]

what about the update of the PollViewSet? shouldn't it have a check whether allow_unregistered_users is true? It inherits from the rest framework mixins, so it may need to be overwritten.

[goapunk]

You mean to check whether a unregistered user trying to vote is allowed to do that ? That's done by the rules/predicates already.

[m4ra]

I left some comments for the django part, but need to do a local test too.
@hom3mad3 can you look more closely to the react part?
BTW can we have the makefile and the github workflows in a separate PR?

[goapunk]

I left some comments for the django part, but need to do a local test too. @hom3mad3 can you look more closely to the react part? BTW can we have the makefile and the github workflows in a separate PR?

I'll make extra PRs but we will have to merge the workflow before this then and rebase it

[m4ra]

@goapunk tried to test it locally, but we cannot set the allowed_unregistered_users from the poll's dashboard yet. Maybe could be a checkbox in the basic settings? For registered users works as expected.

[goapunk]

@goapunk tried to test it locally, but we cannot set the allowed_unregistered_users from the poll's dashboard yet. Maybe could be a checkbox in the basic settings? For registered users works as expected.

@m4ra it works for me, the checkbox is there (in the Poll setting). Not sure why it's not working for you.

[m4ra]

LGTM, thank you!