Skip to content

Commit

Permalink
Fix jacoco report paths 2 (#121)
Browse files Browse the repository at this point in the history
* fix(sonar-push.yml): update the action used to download test results artifact to use dawidd6/action-download-artifact@v2
feat(sonar-push.yml): add path parameter to specify the target directory for downloaded artifact

* chore(sonar-push.yml): update Maven command to skip tests during package phase to improve build performance

* fix(sonar-pull-request.yml): fix the variable name from sonar.login to sonar.token to correctly pass the Sonar token
fix(sonar-push.yml): remove unnecessary path configuration for test-reports-jdk-17-ubuntu-latest job

* chore(sonar-push.yml): remove unnecessary path configuration for test-reports-jdk-17-ubuntu-latest job
  • Loading branch information
jandroav authored Oct 25, 2023
1 parent 305c8c3 commit fbd2380
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/sonar-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
AWS_REGION: "us-east-1"
run: |
mvn -B -Daws.region="us-east-1" -Dsonar.login=$SONAR_TOKEN \
mvn -B -Daws.region="us-east-1" -Dsonar.token=$SONAR_TOKEN \
-Dsonar.pullrequest.key=${{ github.event.pull_request.number }} \
-Dsonar.pullrequest.branch=${{ github.event.pull_request.head.ref }} \
-Dsonar.pullrequest.base=${{ github.event.pull_request.base.ref }} \
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/sonar-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ jobs:
workflow: test.yml
name: test-reports-jdk-17-ubuntu-latest
repo: ${{ github.repository }}
path: ./target
if_no_artifact_found: warn
workflow_conclusion: ""

Expand Down Expand Up @@ -113,6 +112,6 @@ jobs:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
AWS_REGION: "us-east-1"
run: |
mvn -B -Daws.region="us-east-1" -Dsonar.login=$SONAR_TOKEN \
mvn -B -Daws.region="us-east-1" -Dsonar.token=$SONAR_TOKEN \
-Dsonar.scm.revision=${{ github.event.pull_request.head.sha }} \
package -DskipTests sonar:sonar

0 comments on commit fbd2380

Please sign in to comment.