Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Strange output for logging with no styles #7

Closed
mike-north opened this issue Aug 2, 2018 · 1 comment
Closed

[bug] Strange output for logging with no styles #7

mike-north opened this issue Aug 2, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@mike-north
Copy link
Contributor

I'm seeing some extra strings logging when not using colors. Here's a test that will fail and demonstrate the problem ( merging #6 is required for this test to work)

import Logger from 'bite-log';
import { makeTestPrinter } from './test-helpers';

QUnit.module('Log messages with no colors');

QUnit.test('Logging without styles', assert => {
  const printer = makeTestPrinter();
  const logger = new Logger(4, printer);
  logger.warn('a warning');
  logger.debug('a debug');
  logger.log('a log');
  logger.error('an error');

  // Make sure each of the messages are correct
  assert.deepEqual(printer.messages, {
    debug: [ // one call to console.debug
       ['a debug'] // that passes a single argument (i.e., console.debug('a debug')   )
     ],
    error: [['an error']],
    log: [['a log']],
    warn: [['a warning']]
  });
});
@lisaychuang lisaychuang added the bug Something isn't working label Aug 2, 2018
lisaychuang added a commit that referenced this issue Aug 3, 2018
@lisaychuang
Copy link
Owner

🎉 This issue has been resolved in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants